Re: PCI memory allocation bug with CONFIG_HIGHMEM

[Eric W. Biederman]

Andi Kleen <ak@xxxxxxxxxxxxx> writes:

> On Tue, Jan 06, 2004 at 07:27:33AM -0800, Linus Torvalds wrote:
> > 
> > 
> > On Tue, 6 Jan 2004, Andi Kleen wrote:
> > > 
> > > In my opinion it would have been cleaner if the aperture had always
> > > an reserved entry in the e820 map.
> > 
> > That does sound like a bug in the AGP drivers. It shouldn't be hard at all 
> > to make them reserve their aperture.
> > 
> > Hint hint.
> 
> No, it's a bug in the BIOS that they're not marked. But I've actually
> seen a BIOS that marked it and it lead to the Linux AGP driver failing
> (due to some interaction with how setup.c sets up resources). So the Linux
> driver currently even relies on the broken state.

And mtd map drivers for rom chips run into the same problem except in
that case regions is almost always reserved by the BIOS.

Which means it's just silly for the drivers to fail when request_mem_region
fails.  They are looking at the hardware and know where the regions are, and
there is not a parent device we can request a subregion from when it is the
BIOS that reserves the region.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/