Re: In fs/proc/array.c error in function proc_pid_stat

[Marco Roeland]

On Saturday December 13th 2003 William Lee Irwin III wrote:

> A quick reading of the patch (BTW, your MUA is mangling whitespace)
> reveals it's merely creating a local variable, which should have no
> bearing on code generation.

It shouldn't indeed, but it does anyway. The main fault here is some
bug that RedHat's gcc 2.96 has with dealing with 'unsigned long long'
variables. It seems to be partly triggered by the relative complexity
of the very long printf statement it's part of in this file. An earlier
patch that *only* broke up the printf (so without the local variable)
also fixed compilation for some people, though not for all. Changing
some random local variable to 'volatile' also fixed compilation.

> i.e. the compiler is broken.

It's a known *bug*, and seems to be triggered in the current 2.6.0-test
series for gcc 2.96 only in this particular function. Perhaps 'broken'
is a bit too harsh!

> Bad code generation can cause runtime problems too; upgrading to a
> bugfixed compiler is the only sound course of action.

Perhaps. But older (server) platforms with this compiler are still in
wide use, if a simple patch can make use of an otherwise reasonable
compiler again, what's the big deal. And on these platforms dual
installing two versions of gcc (and especially g++ for userspace) can
lead to other mistakes and very hard to debug artifacts from mixed
object code.
-- 
Marco Roeland, who strangely enough only uses Debian unstable himself!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/