Re: [linux-usb-devel] Re: [OOPS, usbcore, releaseintf] 2.6.0-test10-mm1

[Oliver Neukum]

> (1) If both subsys.rwsem and dev->serialize are taken, then
> subsys.rwsem must be taken first.

Yes.
 
> (2) dev->serialize atomizes changes to the struct usb_device.
> 
> Why then is dev->serialize not taken in usb_reset_device
> (except in a dud code path)?
> 
> Also, why isn't dev->serialize enough to protect against
> probe() during usb_reset_device?  After all, won't
> dev->serialize be held during the probe calls (I didn't
> check this and I'm in need of coffee - I hope I'm on the
> right planet...)

In the current code definitely not.
You must make sure that the configuration is still available.
Guarding against probe() during reset is not enough.
AFAIK David is currently rewriting this.

	Regards
		Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/