Re: 2.6.0-test9 - poor swap performance on low end machines

[Con Kolivas]

[snip original discussion thrashing swap on 2.6test with 32mb ram]

Chris

By an unusual coincidence I was looking into the patches that were supposed to 
speed up application startup and noticed this one was merged. A brief 
discussion with wli suggests this could cause thrashing problems on low 
memory boxes so can you try this patch? Applies to test11.

Con
--- linux-2.6.0-test11-base/mm/filemap.c	2003-11-24 22:18:56.000000000 +1100
+++ linux-2.6.0-test11-fremap/mm/filemap.c	2003-12-09 01:17:47.793384425 +1100
@@ -1285,10 +1285,6 @@ static int filemap_populate(struct vm_ar
 	struct page *page;
 	int err;
 
-	if (!nonblock)
-		force_page_cache_readahead(mapping, vma->vm_file,
-					pgoff, len >> PAGE_CACHE_SHIFT);
-
 repeat:
 	size = (i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
 	if (pgoff + (len >> PAGE_CACHE_SHIFT) > size)