Re: [PATCH 2.6.0-test11] VFAT fix for UTF-8 and trailing dots

[OGAWA Hirofumi]

Michal Rokos <m.rokos@xxxxxxxxxx> writes:

> I don't know... Functions in nls_base.c have specification the same as
> those from userspace (defined by ISO/ANSI C or UNIX98).
> 
> Probably we should. This was meant as minimal patch.
> 
> In case you'll be modifiing nls_base.c, please, decide whether this
> shouldn't be in...
> 
> 
> --- linux-2.6.0-test11/fs/nls/nls_base.c.old	2003-11-26 21:44:31.000000000 +0100
> +++ linux-2.6.0-test11/fs/nls/nls_base.c	2003-12-06 20:09:01.000000000 +0100
> @@ -99,6 +99,7 @@ utf8_mbstowcs(wchar_t *pwcs, const __u8 
>  			}
>  		} else {
>  			*op++ = *ip++;
> +			n--;
>  		}
>  	}
>  	return (op - pwcs);
> > 
> > For example, utf8_mbstowcs(outbuf, outlen, inbuf, inlen);
> > 
> 
> I'd would propose uft8_mbsntowcs(outbuf, outlen, inbuf, inlen);

Whoops, sorry. You are right.

But I really like the interface like iconv() than this. And current
nls interfaces also...

Anyway, I think your patches fix some bugs right now.
I'll submit the your both patches.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/