Re: 2.6.0-test9-mm4

From: bill davidsen
Date: Mon Nov 24 2003 - 16:39:06 EST


In article <20031121130810.GQ22764@xxxxxxxxxxxxxx>,
William Lee Irwin III <wli@xxxxxxxxxxxxxx> wrote:

| diff -prauN mm4-2.6.0-test9-1/mm/memory.c mm4-2.6.0-test9-default-2/mm/memory.c
| --- mm4-2.6.0-test9-1/mm/memory.c 2003-11-19 00:07:15.000000000 -0800
| +++ mm4-2.6.0-test9-default-2/mm/memory.c 2003-11-19 18:08:49.000000000 -0800
| @@ -1424,7 +1424,7 @@ do_no_page(struct mm_struct *mm, struct
| pte_t entry;
| struct pte_chain *pte_chain;
| int sequence = 0;
| - int ret;
| + int ret = VM_FAULT_MINOR;
|
| if (!vma->vm_ops || !vma->vm_ops->nopage)
| return do_anonymous_page(mm, vma, page_table,

Good show, I would have expected the compiler to whine if there was a
path out of a proc which returned an unset value. Or did it, and I
didn't try w/o the patch to see it?
--
bill davidsen <davidsen@xxxxxxx>
CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/