Re: patch for 2.4.22 sbp2 hang when loaded with devices already connected

From: Ben Collins
Date: Mon Oct 20 2003 - 20:13:46 EST


On Mon, Oct 20, 2003 at 10:40:23PM -0200, Alexandre Oliva wrote:
> We were free()ing a packet before sbp2_agent_reset() had a chance to
> wake up on its semaphore, which would often cause sbp2 to hang in
> `initializing' state if it was loaded when firewire devices were
> already connected to the host. Details of the symptoms at
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=103821
>
> This patch fixes it. I guess Ben likes it because he sent me a very
> similar patch to test just as I was finishing testing this one :-)
>
> Thanks, Ben, for helping me figure out what was going on!

Please let me send the patch to Marcelo. I have to get this into our
repo, and merge things around back to Marcelo, else it makes things
harder later.

Thanks for following through with the debug to track this down.

--
Debian - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
WatchGuard - http://www.watchguard.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/