Re: [patch][1/3] qlogic: use scsi_host_alloc instead scsi_register

From: Mike Christie
Date: Thu Oct 16 2003 - 16:36:40 EST


Aristeu Sergio Rozanski Filho wrote:

--- linux/drivers/scsi/qlogicfas.c.orig 2003-10-15 23:41:52.000000000 -0200
+++ linux/drivers/scsi/qlogicfas.c 2003-10-15 23:41:28.000000000 -0200
@@ -671,7 +671,7 @@
if (qlirq >= 0 && !request_irq(qlirq, do_ql_ihandl, 0, "qlogicfas", NULL))
host->can_queue = 1;
#endif
- hreg = scsi_register(host, 0); /* no host data */
+ hreg = scsi_host_alloc(host, 0); /* no host data */
if (!hreg)

I think this will break the non-PCMCIA version now. scsi_register also adds the host to the template's legacy_hosts list. With your patch init_this_scsi_driver will call the template's detect function then never call scsi_add_host and scsi_scan_host because that list is empty.


Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/