Re: oops when removing sbp2 module

From: Patrick Mansfield
Date: Sun Oct 05 2003 - 22:37:53 EST


On Mon, Oct 06, 2003 at 01:08:27PM +1000, Paul Mackerras wrote:

> That fixes it, it no longer oopses on removing sbp2. As before I get
> a message saying "Device 'fw-host0' does not have a release()
> function, it is broken and must be fixed." I assume that is a problem
> with the sbp2 module.
>
> The code in the patch looks a little worrying to me, though. Is there
> some lock we have taken to ensure that no other process could be
> modifying sdev->access_count at the same time? Also, what is to stop
> some other process from noticing that sdev->access_count is 0 and
> calling device_del(&sdev->sdev_gendev) ?

Yes, it's a known problem, there is also a comment in the code, Christoph
was working on it.

-- Patrick Mansfield
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/