[PATCH] sysklogd: use up-to-date query_module() routine

From: Kelledin
Date: Sat Oct 04 2003 - 12:17:25 EST


On Friday 03 October 2003 08:36 pm, Kelledin wrote:
> 2) migrate klogd to use query_module() rather than stepping
> through /dev/kmem. query_module() should provide everything
> that klogd normally pokes around /dev/kmem for. Does it rely
> indirectly on being able to step through kmem? I hope not...

Well, I settled on this option, and I've got something that seems
to work. The kmem walker hack is no longer needed, the llseek()
VFS limitations are now a pretty moot point, and an
obsolete/dangerous syscall got nudged further towards oblivion.

(Oh, and klogd no longer segv's on my EV56 box, which was really
the point of this exercise to begin with. ;)

I've attached the patch below in case anyone is interested; I
also sent it off to the sysklogd maintainers (finally found
them). Testing and constructive criticism is encouraged.

--
Kelledin
"If a server crashes in a server farm and no one pings it, does
it still cost four figures to fix?"

Attachment: sysklogd-1.4.1-querymodules.patch.bz2
Description: BZip2 compressed data