Re: PATCH 2.6.0-test6-mm2] aio ref count during retry

[Andrew Morton]

Daniel McNeil <daniel@xxxxxxxx> wrote:
>
> Here is the patch for AIO retry to hold an extra ref count.
> The patch is small, but I wanted to make sure it was safe.
> I spent time looking over the retry code and this patch looks
> ok to me.  It is potentially calling put_ioctx() while holding
> ctx->ctx_lock, I do not think that will cause any problems.
> This should never be the last reference on the ioctx anyway,
> since the loop is checking list_empty(&ctx->run_list).

So...  if the refcount is never zero in there, why are you changing it to
take an additional reference?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/