Re: [PATCH v3] check headers for complete includes, etc.

From: Sam Ravnborg
Date: Wed Oct 01 2003 - 16:11:59 EST


On Wed, Oct 01, 2003 at 08:01:14PM +0200, Jörn Engel wrote:
> > > +my $basename = "lib/header";
> > I much rather have it be: include/headercheck
> > then people realise where eventual temporary files comes from.
>
> Doesn't work in include/, there is no include/Makefile. But lib/ is a
> hack, I agree.

Sigh, OK.

> > So we need something like the following here: (untested)
> > >
> > > +headercheck: prepare-all
> > > + $(PERL) scripts/checkheader.pl $(if $(KBUILD_VERBOSE),-verbose)
> > > +

Forgot that KBUILD_VERBOSE is always defined.
Try:
$(if $(KBUILD_VERBOSE:0=),--verbose)

prepare-all exist in BK-latest.
The purpose is to create the asm-$(ARCH) -> asm symlink.
Add an dependency on include/asm, that should do it.

Try:
make mrproper
make headercheck

To test it before and after.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/