Re: [PATCH] CONFIG_* In Comments Considered Harmful

[Sam Ravnborg]

On Wed, Oct 01, 2003 at 02:26:19PM +0100, Matthew Wilcox wrote:
> 
> I reviewed the dependency list for a file this morning to see why it was
> being unnecessarily recompiled (a little fetish of mine, mostly harmless).
> I was a little discombobulated to find this line:
> 
>     $(wildcard include/config/higmem.h) \

I was a design decision not to parse comments.
Tradeoff between speed and accurateness.
And usually CONFIG_SYMBOLs referred in comments are also used.

The mis-behaviour is not documented in other places than in fixdep
itself - and that's not a place I expect people to look anyway.
If I at some point in time manage to convince myself to write a
how-to-compile-the-kernel I will try to include a section of
known shortcoming. This being one of them.

	Sam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/