Re: [PATCH] linuxabi

[Daniel Jacobowitz]

On Wed, Oct 01, 2003 at 04:34:37AM +0100, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
> On Wed, Oct 01, 2003 at 04:05:57AM +0200, Bernd Eckenfels wrote:
>  
> > > +#define MS_NODIRATIME  2048    /* Do not update directory access times */
> > > +#define MS_BIND                4096
> > > +#define MS_POSIXACL    (1<<16) /* VFS does not apply the umask */
> > 
> > can we clean that up? with shifting, without shifting, with comments and without comments? I suggest to use the linuxdoc comments mandatory for the abi files.
> 
> 
> ... and make it enum, while we are at it.  It's cleaner, it survives cpp
> and it can be handled by gdb et.al. in sane way.
> 
> Unless we really want to support pre-v7 compilers, there is no benefit
> in using #define for such constants.

... although with -g3 the GDB argument goes away; but I'm not arguing
about the surviving-cpp part.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/