Re: [PATCH] expand_resource

[Matthew Wilcox]

On Tue, Sep 30, 2003 at 11:33:52PM +0100, Russell King wrote:
> On Tue, Sep 30, 2003 at 11:14:11PM +0100, Matthew Wilcox wrote:
> > /**
> >  * expand_resource - Expand an existing resource
> >  * @res: Resource already linked into the resource tree.
> >  * @size: Amount of additional space requested below @res.
> >  * @align: Required alignment of new space.
> >  *
> >  * This function is intended to be called when we need more space
> >  * below an existing resource than currently exists.  The @size and
> >  * @align parameters describe the requirements of the child resource,
> >  * not the parent.  Note that this call does not attempt to expand
> >  * the parent of @res as that might require reprogramming devices.
> >  * If a caller would like this behaviour, they must handle the recursion.
> >  */
> > 
> > > My main
> > > question though is - what is the intended purpose of "align" ?  As
> > > it is implemented, it seems to have a weird behaviour:
> > > 
> > > - if we expand the "end" of the resource, we round it towards an
> > >   address which is a multiple of align, but "start" may not be
> > >   a multiple of align.
> > > - if we expand "start", we round it down towards a multiple of
> > >   align.  However, "end" may not be a multiple of align.
> 
> Ok, your description covers the latter case, and seems quite reasonable
> given the arguments.  The former case seems to be a little less clear
> though.

I don't understand what you mean here ... Expanding start is clear,
but expanding end isn't clear?

> The problem with expand_resource as it currently stands is that it can
> expand either at the start or the end of the resource, and we don't know
> which it is going to do.  PCMCIA is one example where this information
> matters - not only do we need to know the right IO range for each IO
> window, but we also need to know the IO address for each device.
> 
> This means that if we were to expand these window resources, we must
> know where the new space was allocated.
> 
> I think we can both agree that saving the old resources start, end
> and then comparing it after expand_resource() is fairly disgusting.

Certainly.  For CCIO, we just program both high and low registers.
I guess we could do something like returning the value that changed
and in the caller:

	int new = expand_resource(res, size, align);

	if (new < 0) {
		return new;
	} else if (new == res->start) {
		/* program start */
	} else {
		/* program end */
	}

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/