Re: include/linux/efs_fs.h declares a symbol

From: viro
Date: Wed Oct 01 2003 - 08:16:44 EST


> Al Viro: There is no maintainer for efs in the kernel MAINTAINERS
> file. Is this filesystem orphaned?

Beats me. As far as I can see, all updates to it were 3rd-party. It's
either abandoned, or never required specific patches too badly (also
quite possible in this case).

It went into the tree in 2.3.2 and from there to 2.6.0-test6 I see nothing
that would look like maintainer's update. OTOH, it's read-only and shouldn't
be too badly broken (or hard to keep alive).

Outside of trunk (i.e. in 2.4.16--) we have a backport of global 2.5 change
(sb_bread()) and check for set_blocksize() failures (from Alan). BTW, the
latter patch is missing in 2.5. Its equivalent would be

--- B6/fs/efs/super.c Mon Jun 23 07:23:09 2003
+++ B6-efs/fs/efs/super.c Wed Oct 1 08:58:35 2003
@@ -218,7 +218,11 @@
memset(sb, 0, sizeof(struct efs_sb_info));

s->s_magic = EFS_SUPER_MAGIC;
- sb_set_blocksize(s, EFS_BLOCKSIZE);
+ if (!sb_set_blocksize(s, EFS_BLOCKSIZE)) {
+ printk(KERN_ERR "EFS: device does not support %d byte blocks\n",
+ EFS_BLOCKSIZE);
+ goto out_no_fs_ul;
+ }

/* read the vh (volume header) block */
bh = sb_bread(s, 0);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/