Re: [PATCH] new ioctl type checking causes gcc warning

[Kevin P. Fleming]

Arnd Bergmann wrote:
> Inside the kernel, the first definition has to be changed to
> something like:
>
> #define BLKGETSIZE64    _IOR(0x12,114,size_t) /* broken: actually __u64 */
> or
> #define BLKGETSIZE64    _IOR_BAD(0x12,114,sizeof(__uint64_t)) /* broken */
>
> in order to get a definition that will pass the check and
> generate the well-known number.

That's strange. I did some testing with a small application (blockdev) 
that uses this ioctl yesterday, and strace did not show any difference 
between the correct and incorrect definitions. I could change the 
definition back and forth and the application continued to work 
correctly. I'll have to go back and figure out what I was doing wrong :-)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/