Re: [OOPS] 2.4.22 / HPT372N

[Bartlomiej Zolnierkiewicz]

On Friday 12 of September 2003 12:48, Alan Cox wrote:
> On Gwe, 2003-09-12 at 10:41, Ronny Buchmann wrote:
> > I will test with cdrom attached later today.
> > Currently I have one disk on each channel.
> >
> > I had another look at hpt.c(from highpoint) and hpt366.c and found this:
> > --- linux-2.4.22-ac1/drivers/ide/pci/hpt366.c.orig	2003-09-11
> > 21:29:06.000000000 +0200
> > +++ linux-2.4.22-ac1/drivers/ide/pci/hpt366.c	2003-09-12
> > 01:05:44.000000000 +0200
> > @@ -713,7 +713,7 @@
> >
> >  	/* Reconnect channels to bus */
> >  	outb(0x00, hwif->dma_base+0x73);
> > -	outb(0x00, hwif->dma_base+0x79);
> > +	outb(0x00, hwif->dma_base+0x77);
> >  }
>
> Which piece of documentation makes you think that ? So I can double
> check it.
>
> > -	d->channels = 1;
> > +	d->channels = 2;
>
> Need to work out which 372N and others are dual channel but yes

No, "d->channels = 1" is only executed for orginal HPT366 which has separate
PCI configurations for first and second channel.  For HPT372N you have correct
value in hpt366.h - ".channels = 2".

--bartlomiej

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/