Re: [PATCH][2.4.23-pre3] repair mpparse for default MP systems

From: Mathieu Desnoyers
Date: Thu Sep 11 2003 - 22:17:10 EST


* Mikael Pettersson (mikpe@xxxxxxxxx) wrote:
> Mathieu,
>
> This patch for 2.4.23-pre3 should fix the problems your dual
> P5 with default MP config has been having since 2.4.21-pre2.
> Please let us know if it works or not.
>
> /Mikael
>

Yes, I just tested this patch, and everything seems to work fine. Thank
you. :)

The only point I see, which is not triggered on my machine (because of
the absence of ACPI) is this one :

There is also an initialization of this mp_irqs variable in
mp_config_acpi_legacy_irqs from mpparse.c. It only seems to be called
from within acpi_boot_init in acpi.c. So I wonder if it's possible that
we do use default configuration and then also go into
mp_config_acpi_legacy_irqs during the acpi init, thus reserving the
memory twice and forgetting the old pointer, which could lead to an
erratic result.

If it's possible, then there is still a problem in there.

OpenPGP public key: http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/