Re: [2.6 PATCH] Squelch make mandocs warnings

[Michael Still]

Quoting Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>:

Alan, thanks for your prompt comments.

> Looks fine.

Ta.

> Technically xml docbook tags must be lower case but older
> SGML docbook is undefined.

For sure -- there are examples in the current kernel documentation which used
mixed case, which I personally feel is not as nice as lower case. I wanted to
tend on the side of working with whatever documentation we have though, and deal
with making the entire world pretty at some later date.

Note also that the patch only makes the internal handling of the tags case
insensitive -- it doesn't change the case of the tags in the kernel-doc, and it
respects the case the author chose when it emits the tags to the intermediate
SGML files used by mandocs.

> The /tmp handling still does want fixing
> though - it does several things that don't look remotely /tmp safe.

This patch was more a case of putting the temporary files where the user
expected them to be. To me, the risk associated with a poorly intentioned person
substituting incorrect manual pages for the internal kernel APIs is sufficiently
low that I am uncertain if it is worthwhile going with a patch to make this
safer. I'm quite content to be wrong on this point however -- do people feel
that making the mandocs scripts temporary file safe is an important goal?

Cheers,
Mikal

-- 

Michael Still (mikal@xxxxxxxxxxx) | "All my life I've had one dream,
http://www.stillhq.com            |  to achieve my many goals"
UTC + 10                          |    -- Homer Simpson


-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/