Re: [patch] 2.6.0-test5: serio config broken?

[Tom Rini]

On Thu, Sep 11, 2003 at 10:38:58AM +0200, Roman Zippel wrote:

> Hi,
> 
> On Wed, 10 Sep 2003, Tom Rini wrote:
> 
> > > Let me paraphrase the dependency the other way round (I'm not sure 
> > > whether the syntax is 100% correct):
> > > 
> > > config KEYBOARD_ATKBD
> > > 	tristate "AT keyboard support" if EMBEDDED || !X86 
> > > 	default y
> > > 	depends on INPUT_KEYBOARD
> > > 	select SERIO=m
> > > 	select SERIO=y if KEYBOARD_ATKBD=y
> > > 	help
> > > 	  ...
> > 
> > Ah yes.
> > 
> > This is similar (the same, even?) to the test3 problem.  Roman, can we
> > get select to somehow pay attention to depend as well?  I do believe
> > it's possible to have A select B, have C depend on Z and end up with:
> > A=y
> > B=y
> > C=n
> 
> Could you give me a complete example, I don't understand yet, what it's 
> exactly supposed to do.

Okay.  The following Kconfig illustrates what I claim to be a bug.
config A
	bool "This is A"
	select B
	
config B
	bool "This is B"
	# Or, depends C=y
	depends C

config C
	bool "This is C"


Running oldconfig will give:
This is A (A) [N/y] (NEW) y
This is C (C) [N/y] (NEW) n
...
And in .config:
CONFIG_A=y
CONFIG_B=y
# CONFIG_C is not set

I claim that this should in fact be:
CONFIG_A=y
CONFIG_B=y
CONFIG_C=y

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/