Re: [PATCH] 2.6 workaround for Athlon/Opteron prefetch errata

From: Jeff Garzik
Date: Thu Sep 11 2003 - 10:07:11 EST


Andi Kleen wrote:
On Thu, 11 Sep 2003 10:34:36 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:


X86_GENERIC is merely an optimization hint (currently it only changes the cache
line size hint) It does not change anything related to correctness. Everything
that handles correctness is checked unconditionally.

When, building non-Pentium4-related code when CONFIG_MPENTIUM4 && !CONFIG_X86_GENERIC, it's OK that the code is incorrect for (picking example) AMD processors.


No 2.6 changed that. On 2.6 you can exchange the kernels.

[that was mainly done for distributions, but helps other users too]


If distributions are not building with CONFIG_X86_GENERIC, then they're broken. So it was rather pointless for 2.6 to "change that."

Luckily, CONFIG_X86_GENERIC allows us the opportunity to be _less_ generic when it's not defined, regardless of what you originally intended ;-)

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/