Re: [PATCH] you have how many nodes??

[Martin J. Bligh]

>> > I think.  We could just say "dang numaq needs five bits", so:
>> > 
>> > 
>> > 	# if BITS_PER_LONG == 32
>> > 	# define ZONE_SHIFT 5
>> > 	# else
>> > 	# define ZONE_SHIFT 10
>> > 	# endif
>> 
>> That's fine with me, do you want me to rediff and send a new patch?
> 
> Well your patch as it stands would appear to break NUMAQ builds, due to
> NUMAQ setting MAX_NUMNODES directly in the arch code.  ia64 is using
> another layer of macroification via NR_NODES instead.
> 
> MAX_NUMNODES, NR_NODES and MAX_NR_NODES appear to be a bit of a mess, and
> they should all be replaced with shift distances anyway.

;-)

Yes, it's a turgid mess.

I'd prefer to define things in terms of MAX_NUMNODES, and derive the shifts
from that if possible - much more intuitive to maintain.
But other than that I agree completely with you.
 
> Could you please get together with Martin Bligh, come up with something
> which works on NUMAQ and your 128 CPU PDA and also cast an eye across the
> other architectures (sparc64, sh, ...)?  It all needs a bit of thought and
> a spring clean.

I'll have a look, I'm sure we can come up with something between us.

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/