Re: [Patch] asm workarounds in generic header files

[David Mosberger]

>>>>> On 10 Sep 2003 12:22:37 -0400, Jes Sorensen <jes@xxxxxxxxxxxxxxxxxx> said:

  Jes> I think this really depends on what you are trying to debug. If
  Jes> you expect the macros to do exactly what they are described to
  Jes> be doing then I'd agree. However every so often when you look
  Jes> up the macros you really want to look at the details what they
  Jes> are actually doing or even compare them to another arch's
  Jes> implementation to make sure they are behaving the same. At
  Jes> least thats my experience.

That's true for some, but not others.  For example, I'd say that
things like getreg() and setreg() are pretty intuitive.

  Jes> I personally think it's unrealistic to think one can try and
  Jes> debug things in include/asm without being able to read the
  Jes> assembly output in the first place.

Assembly output != GCC asm statements.  There are lots of
assembly-savy folks that have no clue how to read/interpret the GCC
asm syntax.  Those folks have the option of either generating an
assembly file or disassembling the resulting object file.  Both
approaches would let them read the resulting code without having to
know exactly how the asm statement (or intrinsic) works.

  David> I think the jury is out on this one.  Clearly it's a huge
  David> benefit if you can make do without inline asm.  GCC has to
  David> make lots of worst-case assumptions whenever it encounters an
  David> asm statement and, due to macros and inlining, the asm
  David> statements are not just hidden in a few leaf routines.

  Jes> Reducing the amount of inline asm in the kernel would be a good
  Jes> thing. It is cetainly one of those things that have been abused
  Jes> way beyond it's intent.

Agreed.

	--david
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/