Re: [PATCH 1/3] netpoll api

From: Matt Mackall
Date: Wed Sep 10 2003 - 04:09:49 EST


On Wed, Sep 10, 2003 at 06:39:35PM +1000, Anton Blanchard wrote:
>
> > Hmmm, linux/irq.h seemed pretty generic. Maybe those other, silly
> > arches can mend their ways?
>
> linux/irq.h:
>
> /*
> * Please do not include this file in generic code. There is currently
> * no requirement for any architecture to implement anything held
> * within this file.
> *
> * Thanks. --rmk
> */
>
> Generic? Nice try :)

But, uh, all my comments show up in a Greek font. Or something..

(the real problem is that I jumped straight to the structure in LXR)

> > Ok, looks like m68k, s390, and sparcx are the only ones not using
> > irq_desc, and only s390 seems to be far from the irq_desc model. Or I
> > could be quite mistaken.
>
> irq_desc will probably die in 2.7, replaced with some helper macros. Its
> not a neat fit for many arches (ppc64 included).

Well I'll come up with something for x86 tomorrow and when helper
macros materialize, I'll use them.

--
Matt Mackall : http://www.selenic.com : of or relating to the moon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/