Re: [PATCH 1/3] netpoll api

[Matt Mackall]

On Wed, Sep 10, 2003 at 12:49:07AM -0700, Andrew Morton wrote:
> Matt Mackall <mpm@xxxxxxxxxxx> wrote:
> >
> > +	spin_lock_irq(&irq_desc[ndev->irq].lock);
> >  +	for(a=irq_desc[ndev->irq].action; a; a=a->next) {
> 
> Lots of architectures do not use irq_desc[].   You'll need abstracted
> per-arch primitives for functions such as this.

Hmmm, linux/irq.h seemed pretty generic. Maybe those other, silly
arches can mend their ways?

Ok, looks like m68k, s390, and sparcx are the only ones not using
irq_desc, and only s390 seems to be far from the irq_desc model. Or I
could be quite mistaken.

I'll be damned if I know what's going on with s390, so I'm not sure
how to get from here to there in terms of coming up with an API for
poking around in ISR lists. Unless you're suggesting I simply make
try_to_find_handler_dev(dev, irq) which seems a little ungainly.

-- 
Matt Mackall : http://www.selenic.com : of or relating to the moon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/