Re: [PATCH] Power: call save_state on PCI devices along with suspend

[Patrick Mochel]

> Well... that wouldn't help with off-tree drivers...

But, we don't care about out-of-tree drivers, right? :)

> What I mean here is that our PCI driver API defines save_state, we shall
> either "support" it some way, or get rid of it completely... but then we
> lose the ability to move a PCI driver back & forth with 2.4 ... (do we
> care ?)

I think the addition of the method was a mistake and it should be fixed 
up. The fact there are only those 4 users should make it trivial in both 
2.6 and 2.4 to do so. 

> If you prefer just fixing those 4 ones, then let's get rid of the
> save_state field in pci_driver completely...

I completely agree. 


	Pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/