Re: [PATCH] Re: Linux 2.6.0-test5

[walt]

Jeff Garzik wrote:
> Note that people seeing "ifconfig down ... ifconfig up" problems need to 
> apply this patch.  (to 2.4.23-pre, too)
>
>     Jeff
>
>
>
> ------------------------------------------------------------------------
>
> diff -Nru a/net/core/dev.c b/net/core/dev.c
> --- a/net/core/dev.c	Mon Sep  8 18:14:36 2003
> +++ b/net/core/dev.c	Mon Sep  8 18:14:36 2003
> @@ -851,7 +851,11 @@
>  	 * engine, but this requires more changes in devices. */
>  
>  	smp_mb__after_clear_bit(); /* Commit netif_running(). */
> -	netif_poll_disable(dev);
> +	while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> +		/* No hurry. */
> +		current->state = TASK_INTERRUPTIBLE;
> +		schedule_timeout(1);
> +	}
>  
>  	/*
>  	 *	Call the device specific close. This cannot fail.

I wrote recently:

> Okay!  I'm at least back where I started.  This patch doen't fix the
> ifconfig down/up problem, but it does reverse the disastrous effects
> of the last tg3 updates in both 2.6 and 2.4...

When I wrote that I didn't realize you were referring to a different
thread about ifonfig up/down instead of my long-standing bug.

My reference to the 'disastrous effects' does refer to the problem
described in the 'ifconfig up/down' thread elsewhere in the lkml
today.  Sorry for the confusion.  That problem seems to be fixed
by this patch.  I'll keep hoping for a fix for my other tg3 bug.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/