Re: [PATCH] use size_t for the broken ioctl numbers

From: Linus Torvalds
Date: Mon Sep 08 2003 - 13:56:24 EST



On Mon, 8 Sep 2003, Andries Brouwer wrote:

> On Mon, Sep 08, 2003 at 08:13:53AM -0700, Linus Torvalds wrote:
>
> > I'd _much_ rather have a comment than make up some new "bad define" thing.
>
> Pity.

Note that Arnd's "extra-anal check" added a XXX_BAD() define after all,
and I ended up accepting that one, because it had a totally valid usage:
it fixed a real issue not with bad type passing, but with passing types
that are too _big_.

I fixed two cases that I found where this was the case, there might be
others (I did a maxconfig, but on SMP. There might be some UP-only driver
that is affected by this).

But I'm too lazy to go back and fix up the older fixes, so..

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/