Re: [PATCH] use size_t for the broken ioctl numbers

[Linus Torvalds]

On Mon, 8 Sep 2003, Andries Brouwer wrote:
> 
> > -#define BLKELVSET  _IOW(0x12,107,sizeof(blkelv_ioctl_arg_t))/* elevator set */
> > +#define BLKELVSET  _IOW(0x12,107,size_t)/* elevator set */
> 
> Here we lose information - I don't like that.
> Often it is important to know what kind of argument an ioctl has,
> and that info should be easy to find.

In the ones I converted I added a comment. That should be sufficient, and 
if anybody cares strongly, a patch to me to add comments to the ones 
Matthew converted will also be applied.

I'd _much_ rather have a comment than make up some new "bad define" thing.

		Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/