Re: [PATCH 2] Little fixes to previous futex patch

[Jamie Lokier]

Ingo Molnar wrote:
> > Hugh's patch is clever and subtle.  It doesn't exit the loop; the loop
> > continues from "next".
> 
> ugh. It would be much cleaner to simply do a list_add() instead of a
> list_add_tail(). (the ordering of the queue doesnt matter anyway)

Why do you say the order doesn't matter?  If you change the order in
FUTEX_WAIT & FUTEX_WAKE, then "fair" operations aren't fair any more.

Is there a reason why FUTEX_REQUEUE is exempt from this?

-- Jamie

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/