Re: First impressions of reiserfs4

[Rogier Wolff]

On Mon, Sep 08, 2003 at 01:08:26PM +0400, Oleg Drokin wrote:
> Hello!
> 
> On Mon, Sep 08, 2003 at 10:56:41AM +0200, Rogier Wolff wrote:
> > > > There  is no installation program that will fail with: "Sorry, 
> > > > you only have 100 million inodes free, this program will need
> > > > 132 million after installation", and it allows me a quick way 
> > > > of counting the number of actual files on the disk.... 
> > > You cannot. statfs(2) only exports "Total number of inodes on disk" and
> > > "number of free inodes on disk" values for fs. df substracts one from another one
> > > to get "number of inodes in use".
> > So, you report "oids_in_use + 100M" as total and "100M" as free inodes 
> > on disk. Voila!

> Yes, we thought about that too. Need to be careful to not overflow
> "long int".  

> And idea of filesystem with variable amount of inodes over time
> sounds confusing to me, too.  ]

SO? That's actually the case. So it's confusing. So you're confusing
people even more by telling nothing. Great. 

#define LARGE_NUMBER 100000

out->total_inodes = fs->oids_in_use + LARGE_NUMBER; 
if (out->total_inodes < fs->oids_in_use) 
   out -> total_inods = MAXINT;
out -> free_inodes = LARGE_NUMBER; 

Three lines of code fixes that. 

> Well, if current interface does not allow to see all the stuff you want to,
> time to change (introduce new one) interface, anyway.

Fine, introduce a new interface. But report as much as you can on the
old interface. Remember you can read/write/seek files using the 32bit
interface even though the new (seek-, and stat-) interface uses 64
bits.

		Roger. 

-- 
** R.E.Wolff@xxxxxxxxxxxx ** http://www.BitWizard.nl/ ** +31-15-2600998 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
**** "Linux is like a wigwam -  no windows, no gates, apache inside!" ****
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/