Re: [ACPI] Re: [PATCH] 2.6.0-test4 ACPI fixes series (4/4)

[Andrew de Quincey]

On Saturday 06 September 2003 02:22, Jeff Garzik wrote:
> Andrew de Quincey wrote:
> > This patch removes some erroneous code from mpparse which breaks IO-APIC
> > programming
> >
> >
> > --- linux-2.6.0-test4.null_crs/arch/i386/kernel/mpparse.c	2003-09-06
> > 00:23:10.000000000 +0100 +++
> > linux-2.6.0-test4.duffmpparse/arch/i386/kernel/mpparse.c	2003-09-06
> > 00:28:23.788124872 +0100 @@ -1129,9 +1129,6 @@
> >  			continue;
> >  		ioapic_pin = irq - mp_ioapic_routing[ioapic].irq_start;
> >
> > -		if (!ioapic && (irq < 16))
> > -			irq += 16;
> > -
>
> Even though I've been digging through stuff off and on, I consider
> myself pretty darn IOAPIC-clueless.  Mikael, does this look sane to you?

Really breaks on TX150 servers... All IRQs < 16 get +16 added onto them, which 
breaks all IRQ routing. It's also already been removed from 2.4.23-pre3

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/