Re: [PATCH] Re: 2.6.0-test4-mm5

[David S. Miller]

On Wed, 03 Sep 2003 12:32:41 -0400
Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

> David, would you look over this patch and apply/modify?

Applied, thanks Jeff.

> I would prefer to use the generic ethtool_op_get_link, because (a) 
> sungem is already using netif_carrier_xxx, and (b) if ->get_link ever 
> returns an incorrect value, that signals a netif_carrier_xxx bug exists.

Agreed.

> As a tangent, gem_pcs_interrupt appears to call netif_carrier_xxx but 
> not set gem->lstate.  David/Ben, is that a bug?

Doesn't really matter, I don't think the rest of the PCS code even
cares about the setting of gem-lstate.
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html