RE: [PATCH] efivars update

[Tolentino, Matthew E]

Matt,

> Move the unlock up above the status test, else you return while
> holding the lock on failure.

Ouch. Thanks...

> level on printk please.

Fixed.

> Might as well just force the deletion by setting Attributes=0 or
> DataSize=0 or both.  Less chance for userspace error.

Good idea.
 
> Please kill this chunk.  I shouldn't have had it there in the first 
> place. :-)
> 
> Looks great to me!  Thanks again.

Sure thing.  Updated patch attached....

matt

Attachment: linux-2.6.0-test4-efivars2.patch
Description: linux-2.6.0-test4-efivars2.patch