Re: 2.6.0-test4: CONFIG_KCORE_AOUT doesn't compile

[Andrew Morton]

Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> Is there any specific reason to keep CONFIG_KCORE_AOUT or is it time to 
> remove this option?

Time to kill it I suspect.

This fixes the linkage problem:


diff -puN include/linux/proc_fs.h~kcore-aout-build-fix include/linux/proc_fs.h
--- 25/include/linux/proc_fs.h~kcore-aout-build-fix	Tue Aug 26 13:29:07 2003
+++ 25-akpm/include/linux/proc_fs.h	Tue Aug 26 13:29:07 2003
@@ -182,12 +182,6 @@ static inline void proc_net_remove(const
 	remove_proc_entry(name,proc_net);
 }
 
-/*
- * fs/proc/kcore.c
- */
-extern void kclist_add(struct kcore_list *, void *, size_t);
-extern struct kcore_list *kclist_del(void *);
-
 #else
 
 #define proc_root_driver NULL
@@ -223,6 +217,9 @@ static inline void proc_tty_unregister_d
 
 extern struct proc_dir_entry proc_root;
 
+#endif /* CONFIG_PROC_FS */
+
+#if !defined(CONFIG_PROC_FS) || defined(CONFIG_KCORE_AOUT)
 static inline void kclist_add(struct kcore_list *new, void *addr, size_t size)
 {
 }
@@ -230,8 +227,10 @@ static inline struct kcore_list * kclist
 {
 	return NULL;
 }
-
-#endif /* CONFIG_PROC_FS */
+#else
+extern void kclist_add(struct kcore_list *, void *, size_t);
+extern struct kcore_list *kclist_del(void *);
+#endif
 
 struct proc_inode {
 	struct task_struct *task;

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/