Re: [PATCH resend #1] fix cu3088 group write

From: Guillaume Morin
Date: Tue Aug 26 2003 - 13:21:47 EST


Dans un message du 25 aoû à 12:47, Arnd Bergmann écrivait :
> Your fix doesn't look right either. The input string should not be
> longer than BUS_ID_SIZE, including the trailing zero. AFAICS, the
> correct way to solve this is the patch below, but I did not test it.

Well, I did not know that BUS_ID_SIZE was including the trailing zero.
The name does not appear to suggest that. BUS_ID_LEN would have been a
better chose for that imho.

I don't know what you call "not right". My fix was the safest bet. It is
right but yours is cleaner.

--
Guillaume Morin <guillaume@xxxxxxxxxxx>

Marry me girl, be my only fairy to the world (RHCP)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/