Re: [PATCH] Add MOUNT_STATUS ioctl to cdrom device

[Jens Axboe]

On Tue, Aug 26 2003, Christoph Hellwig wrote:
> On Tue, Aug 26, 2003 at 04:09:54PM +0700, Samphan Raruenrom wrote:
> > The only visible feature of this new magicdev is that now
> > GNOME users can eject there CDs (the discs' icon will
> > disappear). The eject button now act as 'umount' command.
> > 
> > One new requirement from this new magicdev is the question
> > "will umount failed?". I have no preference on any way to
> > implement it. Should there be the right way to do it, I'll
> > do so. I can think of many way to implement it (including
> > adding a new lazy-lock mode to cdrom device) but since
> > I have no kernel hacking experience, I need everyone
> > advices. Novice users need this 'eject' button after all.
> 
> This doesn't make sense at all.  Just try the unmount and
> tell the user if it failed - you can't say whether it will
> fail before trying.

Exactly. You poll media events from the drive, and upon an eject request
you try and umount it. If it suceeds, you eject the tray. It's pretty
simple, really.

This mount status patch is seriously broken and misguided.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/