Re: [PATCH] ide: limit drive capacity to 137GB if host doesn't support LBA48

[Bartlomiej Zolnierkiewicz]

On Thursday 14 of August 2003 10:53, Alan Cox wrote:
> On Iau, 2003-08-14 at 02:24, Bartlomiej Zolnierkiewicz wrote:
> >  	hwif->rqsize			= old_hwif.rqsize;
> > -	hwif->addressing		= old_hwif.addressing;
> > +	hwif->no_lba48			= old_hwif.no_lba48;
>
> This change is a bad idea. Its called "addressing" because that is what
> it is about (see SATA and ATA specs). In future SATA addressing becomes
> a 0,1,2 value because 48bits isnt enough, it may get more forms beyond
> that.

Its hwif->addressing not drive->addressing.  Look at the current usage.
It is 1 when host doesn't support LBA48, otherwise its 0.  We can add "real"
hwif->addressing when needed.  IDE driver is already full of unfinished,
unused "features".

--bartlomiej

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/