Re: [PATCH] oops in sd_shutdown
From: Andries Brouwer
Date: Wed Aug 13 2003 - 05:50:33 EST
On Tue, Aug 12, 2003 at 05:24:50PM -0700, Mike Anderson wrote:
> > > Well, this same problem could show upb in any other driver. Could
> > > you instead send a patch to Pat that the driver model never calls
> > > the shutdown method for a driver that hasn't finished ->probe?
> >
> > I think it already will not do that due to taking the bus->subsys.rwsem
> > before calling either probe() or remove().
>
> Is the shutdown being called directly? The shutdown call is protected by
> a different rwsem. Depending on the call graph setting dev->driver on
> return of probe may provide a solution.
Yes, that is precisely what I had considered doing.
> I have not looked at all probe
> routines to understand if this would cause any bad side effects.
>
> Andries,
> Can you send the oops output?
top of stack was reported as (process reboot):
sd_shutdown + 0x22/0x110 NULL deref (namely, sdkp)
i8042_notify_sys
device_shutdown
sys_reboot
do_clock_nanosleep
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/