Re: [PATCH][2.6-mm] cpumask_t - ioapic set_ioapic_affinity

[Andi Kleen]

> -static void set_ioapic_affinity (unsigned int irq, unsigned long mask)
> +static void set_ioapic_affinity (unsigned int irq, cpumask_t mask)
>  {
>  	unsigned long flags;
> +	unsigned int dest;
> +
> +	dest = cpu_mask_to_apicid(mk_cpumask_const(mask));
> +
>  	/*
>  	 * Only the first 8 bits are valid.
>  	 */
> -	mask = mask << 24;
> +	dest = dest << 24;
>  
>  	spin_lock_irqsave(&ioapic_lock, flags);
> -	__DO_ACTION(1, = mask, )
> +	__DO_ACTION(1, = dest, )
>  	spin_unlock_irqrestore(&ioapic_lock, flags);

Looks ok.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/