Re: [PATCH] CodingStyle fixes for drm_agpsupport

[Larry McVoy]

On Mon, Aug 11, 2003 at 12:58:44PM -0400, Jeff Garzik wrote:
> Larry McVoy wrote:
> >A few comments on why I don't like this patch:
> >    1) It's a formatting only patch.  That screws over people who are using
> >       BK for debugging, now when I double click on these changes I'll get
> >       to your cleanup patch, not the patch that was the last substantive
> >       change.
> 
> This is true, but at the same time, in Linux CodingStyle patches 
> culturally acceptable.  I think the general logic is just "don't go 
> overboard; reformat a tiny fragment at a time."

That ought to be balanced with "don't screw up the revision history, people
use it".  It's one thing to reformat code that is unreadable, for the most
part this code didn't come close to unreadable.

> at least don't run the damn lines together like
> 	if (test) foo else bar;
> 		or
> 	if (test) foo
> 	else bar;

I wasn't suggesting that.  I was saying

	if (expr) statement;		// OK

I was not endorsing this sort of unreadable crap:

	if (expr) statement; else statement;

The exception I was saying was reasonable is if you are doing something like

	if (!pointer) return (-EINVAL);

Short, sweet, readable, no worries.  
-- 
---
Larry McVoy              lm at bitmover.com          http://www.bitmover.com/lm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/