Re: [PATCH] Change all occurrences of 'flavour' to 'flavor'

From: Richard B. Johnson
Date: Fri Aug 08 2003 - 10:39:49 EST


On Fri, 8 Aug 2003, Timothy Miller wrote:

>
>
> Jasper Spaans wrote:
> > On Thu, Aug 07, 2003 at 09:42:37PM -0400, Zwane Mwaikambo wrote:
> >
> >
> >>>It changes all occurrences of 'flavour' to 'flavor' in the complete tree;
> >>>I've just comiled all affected files (that is, the config resulting from
> >>>make allyesconfig minus already broken stuff) succesfully on i386.
> >>
> >>Arrrgh! You can't be serious!
> >
> >
> > Yes, I am bloody serious; this patch might look purely cosmetic at first
> > sight.. yet, there's a technical reason for at least one part of it. Grep
> > and see the horror:
> >
> > $ egrep -ni 'flavou?r' fs/nfs/inode.c
> > [snip]
> > 1357: rpc_authflavor_t authflavour;
> > [snip]
>
>
> Ah, for a moment, I was worried that someone was talking about text in
> comments.
>
> Yes, when it comes to spelling of words in variable and type names, I
> think it would be a good idea to be consistent.
>
> What is Linus's preferred spelling? Let's use that.
>

It's a little past April Fool's day. What are you guys
smoking? Next, you'll want to change all the 'i's to
'y's and add 'ing'.

Certainly one might want to change:

int TheVariableThatWillBeUsedAsACounter;

to..
int i;

However, changing the spelling of a variable name is
absurd no matter how you look at it.

Cheers,
Dick Johnson
Penguin : Linux version 2.4.20 on an i686 machine (797.90 BogoMips).
Note 96.31% of all statistics are fiction.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/