Re: [RFC][PATCH] linux-2.6.0-test2_mtrr-race-fix_A0

From: john stultz (johnstul@us.ibm.com)
Date: Wed Aug 06 2003 - 12:15:05 EST


On Wed, 2003-08-06 at 01:52, Mathias Fröhlich wrote:
> Hi,
>
> You should not remove the barrier past mtrr change. If you do that, it is
> possible that cpu's run with inconsistent mtrrs. This can have bad
> sideeffects since at least the cache snooping protocol used by intel uses
> assumptions about the cachability of memory regions. Those information about
> the cachability is also taken from the mtrrs as far as I remember.
> This intel cpu developer manual, which documented the early PII and PPro
> chips, recommended this algorithm. Since actual intel cpus use the same old
> cpu to chipset bus protocol, this old documentation most propably still
> applies.

Hmm. I should dig up that doc. Its a little hazy in my mind, but I think
I understand your description. I'm glad you caught this, as I can't
imagine the subtle bugs that might have popped up.

Well, let me look at it again and see if I can come up with a proper
fix.

Thanks for the knowledgeable feedback and sanity checking!
-john

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:34 EST