Re: [PATCH] fix error return get/set_native_max functions

From: Roman Zippel (zippel@linux-m68k.org)
Date: Tue Aug 05 2003 - 18:15:00 EST


Hi,

On Tue, 5 Aug 2003 Andries.Brouwer@cwi.nl wrote:

> > This change is okay, thanks.
> > However changing coding style is not...
>
> An interesting remark.
>
> I belong to the people who look at kernel source on a screen
> with 80 columns. Code that is wider and wraps is unreadable.

Get a better editor?
While I think 80 columns is a worthwhile goal, I don't see a good reason
to wrap a random line only because it exceeds the limit by a few
characters. What is especially annoying are patches with a one line fix
hidden within 10 other formatting changes (I've seen this already from
you). Please respect others people code and try to avoid randoming
formatting changes or at least keep them separate.

bye, Roman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:30 EST