[PATCH] clarify why DMA gets disabled on broken drives

From: Tomas Szepe (szepe@pinerecords.com)
Date: Tue Aug 05 2003 - 16:29:18 EST


Alan,

I just ran into this and had to look at the sources to find out why
the IDE driver was turning off DMA for a particular drive.

(It's nice to see that this actually works, btw. 8))

-
Tomas Szepe <szepe@pinerecords.com>

Patch against 2.4.22-rc1.

diff -urN a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
--- a/drivers/ide/ide-dma.c 2003-08-05 23:20:48.000000000 +0200
+++ b/drivers/ide/ide-dma.c 2003-08-05 23:24:22.000000000 +0200
@@ -835,7 +835,8 @@
 #ifdef CONFIG_IDEDMA_NEW_DRIVE_LISTINGS
         int blacklist = in_drive_list(id, drive_blacklist);
         if (blacklist) {
- printk("%s: Disabling (U)DMA for %s\n", drive->name, id->model);
+ printk("%s: Disabling (U)DMA for %s (on blacklist)\n",
+ drive->name, id->model);
                 return(blacklist);
         }
 #else /* !CONFIG_IDEDMA_NEW_DRIVE_LISTINGS */
@@ -844,7 +845,7 @@
         list = bad_dma_drives;
         while (*list) {
                 if (!strcmp(*list++,id->model)) {
- printk("%s: Disabling (U)DMA for %s\n",
+ printk("%s: Disabling (U)DMA for %s (on blacklist)\n",
                                 drive->name, id->model);
                         return 1;
                 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:30 EST