On Sat, Aug 02, 2003 at 05:34:38PM -0600, Erik Andersen wrote:
> I have rewritten the init_idedisk_capacity() function and taught
> it to behave itself. It is now much cleaner IMHO
Yes, nice cleanup.
Some comments for later - the patch can be applied as it is:
The assignment
drive->select.b.lba = 0/1;
is done in the first half of init_idedisk_capacity().
I don't think the presence or disabling of HPA has any effect
on b.lba, so there should not be such assignments in the
second, HPA, half.
My standard muttering: id->... should not be modified.
In my source I test drive->head * drive->sect for being nonzero
before dividing.
Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:20 EST