Re: [PATCH] [1/2] random: SMP locking

From: Matt Mackall (mpm@selenic.com)
Date: Sat Aug 02 2003 - 09:43:10 EST

Next message: Rob Landley: "More fun with menuconfig..."
Previous message: Herbert Pötzl: "nodev, noexec, nosuid, ro for --bind mounts?"
In reply to: Zwane Mwaikambo: "Re: [PATCH] [1/2] random: SMP locking"
Next in thread: Zwane Mwaikambo: "Re: [PATCH] [1/2] random: SMP locking"
Reply: Zwane Mwaikambo: "Re: [PATCH] [1/2] random: SMP locking"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Aug 02, 2003 at 08:35:22AM -0400, Zwane Mwaikambo wrote:
> On Sat, 2 Aug 2003, Andrew Morton wrote:
> > Cannot perform userspace access while holding a lock - a pagefault could
> > occur, perform IO, schedule away and the same CPU tries to take the same
> > lock via a different process.
>
> Perhaps might_sleep() in *_user, copy_* etc is in order?

Wouldn't have caught this case - this interface hasn't actually been
used/useful for many years as it only gives access to one of the
pools and has never been atomic either.

-- 
Matt Mackall : http://www.selenic.com : of or relating to the moon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Rob Landley: "More fun with menuconfig..."
Previous message: Herbert Pötzl: "nodev, noexec, nosuid, ro for --bind mounts?"
In reply to: Zwane Mwaikambo: "Re: [PATCH] [1/2] random: SMP locking"
Next in thread: Zwane Mwaikambo: "Re: [PATCH] [1/2] random: SMP locking"
Reply: Zwane Mwaikambo: "Re: [PATCH] [1/2] random: SMP locking"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 07 2003 - 22:00:19 EST