Re: [PATCH] i2c driver changes 2.6.0-test1

From: Marcelo Penna Guerra (
Date: Wed Jul 23 2003 - 12:43:55 EST


This code doesn't work well. I was porting this code to 2.5 myself, so I did
some fixes to the code in 2.6.0-test1-ac3.

On Saturday 19 July 2003 12:54, Greg KH wrote:

> + smbus->adapter.algo_data = smbus;
> +*/

The problem is here. If you leave this line commented out, you'll have
problems when inserting the chip module.

> smbus->adapter = nforce2_adapter;

Also, I don't see the point in commenting out all this lines just to introduce
a nforce2_adapter struct. If this is the correct aprouch, just remove the
duplicate code instead of just commenting it out.

Attached is a patch to fix this problems. I can't test it very well as I can
only see the sensors in my board with i2c-isa, but everything loads fine.
This patch also moves the PCI ids to the pci_ids.h file.

Marcelo Penna Guerra

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:50 EST