Re: [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b4).

From: Christoph Hellwig (hch@infradead.org)
Date: Fri Jul 18 2003 - 14:12:43 EST


On Fri, Jul 18, 2003 at 03:46:42PM +0200, Arjan van de Ven wrote:
> On Fri, 2003-07-18 at 13:23, Christoph Hellwig wrote:
> >
> > - qla2x00_intr_handler should use spin_lock, not spin_lock_irqsave
>
> possibly correct; on x86 irq handlers run with interrupts enabled for
> example; just too dangerous to do this esp if error recovery and similar
> code calls this from process context as well (iirc a few places do)

Well, that's only true for SA_INTERRUPT. But I missed that qla2xxx
sets this. So drop ■hat comment.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Jul 23 2003 - 22:00:35 EST